Implementation of break lines, sub & superscripts and bold & italic styles in WebGL texts #3207

archmoj · 2018-11-02T01:34:19Z

This PR fixes plotly/plotly.R#1334 and plotly.js #3196 as well as #2551 and #1165 by enabling webgl texts to be drawn on multiple lines using < br > tags. Also another feature is added i.e. to enable using various styles namely italic, bold, sub and super script with webgl texts.
@etpinard
@alexcjohnson

archmoj · 2018-11-02T03:14:40Z

package.json

@@ -78,9 +78,9 @@
    "gl-mat4": "^1.2.0",
    "gl-mesh3d": "^2.0.1",
    "gl-plot2d": "^1.3.1",
-    "gl-plot3d": "^1.5.10",
+    "gl-plot3d": "git://github.com/gl-vis/gl-plot3d.git#1c8aadc60eb026bd839f3c4e4a73dab719748843 ",


mikolalysenko/vectorize-text@master...archmoj:issue-br3d

… webgl

This reverts commit 07aecd1.

archmoj · 2018-11-13T20:23:29Z

package-lock.json

@@ -4554,7 +4539,7 @@
        "glslify": "^6.1.0",
        "robust-orientation": "^1.1.3",
        "split-polygon": "^1.0.0",
-        "vectorize-text": "^3.0.0"
+        "vectorize-text": "git://github.com/archmoj/vectorize-text.git#457db88a269e6412c6f6007f1ba88d06bdfbc08c"


Link to corresponding PR on vectorize-text module
mikolalysenko/vectorize-text#8

etpinard · 2018-11-14T14:39:53Z

@archmoj wait, how did go about removing the line break in date labels on 3D axis ticks? I don't anything in plotly.js. Did you disable <br> formatting for all 3D axis ticks?

I was imagining a small if-block in plotly.js that would remove <br> from data tick text values. That way, graphs like https://codepen.io/etpinard/pen/bQqjvw that use ticktext and tickvals could still appear on multiple lines in the tick labels.

I apologise if my comments weren't clear enough.

archmoj · 2018-11-14T15:00:24Z

Thanks for the comment. I could easily control that in gl-axes3d and plotly.js side too.
And I am sure we could keep the vectorize-text this way as is more flexible now : )

archmoj · 2018-11-16T17:12:23Z

package.json

@@ -77,10 +77,10 @@
    "gl-line3d": "^1.1.5",
    "gl-mat4": "^1.2.0",
    "gl-mesh3d": "^2.0.1",
-    "gl-plot2d": "^1.3.1",
-    "gl-plot3d": "^1.5.10",
+    "gl-plot2d": "git://github.com/gl-vis/gl-plot2d.git#bd8a9798589ca4461604ca041479820d6a915103",


https://github.com/gl-vis/text-cache/compare/issue-br3d

archmoj · 2018-11-16T17:14:25Z

package.json

-    "gl-plot2d": "^1.3.1",
-    "gl-plot3d": "^1.5.10",
+    "gl-plot2d": "git://github.com/gl-vis/gl-plot2d.git#bd8a9798589ca4461604ca041479820d6a915103",
+    "gl-plot3d": "git://github.com/gl-vis/gl-plot3d.git#99bd1d20bcec61bdba97cd86bcb2cd5b8b52bd17",


https://github.com/gl-vis/gl-axes3d/compare/issue-br3d

archmoj · 2018-11-16T17:16:26Z

package.json

    "gl-pointcloud2d": "^1.0.1",
-    "gl-scatter3d": "^1.0.14",
+    "gl-scatter3d": "git://github.com/gl-vis/gl-scatter3d.git#4353e3493e4e64d363c334fb62ac3e054c50fbf3",


https://github.com/gl-vis/gl-scatter3d/compare/issue-br3d

archmoj · 2018-11-19T16:21:33Z

The modules are upgraded and the tests are passed on CI.
@etpinard Could I continue & resolve the conflicts before merge this?

etpinard · 2018-11-19T16:23:03Z

Yes go ahead and resolve the conflict in this PR. Thanks!

etpinard · 2018-11-19T16:43:05Z

package-lock.json

@@ -4804,7 +4804,7 @@
    },
    "gl-select-static": {
      "version": "2.0.2",
-      "resolved": "https://registry.npmjs.org/gl-select-static/-/gl-select-static-2.0.2.tgz",
+      "resolved": "http://registry.npmjs.org/gl-select-static/-/gl-select-static-2.0.2.tgz",


Please put back https here.

etpinard · 2018-11-19T17:08:29Z

Great PR 💃

etpinard · 2018-11-19T17:09:08Z

... make sure to close

once merged.

archmoj added 2 commits November 1, 2018 21:15

support for multi-line texts

f607841

correct baselines

87de8bf

archmoj added bug something broken status: reviewable labels Nov 2, 2018

archmoj commented Nov 2, 2018

View reviewed changes

using title options in the new mock

eb8c36c

archmoj added status: in progress and removed status: reviewable labels Nov 2, 2018

archmoj added 6 commits November 2, 2018 14:10

using vect-text with line-spacing

8bc3da1

new baseline images using different default line spacing

a0716a2

using new vectorize-text module - no need to convert from html for webgl

342c3f5

support of br and sup elements for webgl texts

bd11b26

updated the baseline image of new mock

b5fc64a

updated baseline image

d9ab3c0

archmoj added status: reviewable and removed status: in progress labels Nov 2, 2018

archmoj mentioned this pull request Nov 2, 2018

bug with subscripts and superscripts in 3D #1165

Closed

archmoj added 6 commits November 4, 2018 01:17

adding italic bold super and sub in webgl text

945f5cb

updated baseline images with bold italic and sub-super script text in…

a9249f8

… webgl

adjust sub & sup positions and size

8a91eae

updated baselines using adjusted sub and superscripts positions and size

97909b0

applying improvements to gl-plot2d

4231e51

check not to assign undefined style

1178ee2

archmoj changed the title ~~Supporting break lines in texts in 3D scenes~~ Implementation of break lines, sub & superscripts and bold & italic styles in WebGL texts Nov 4, 2018

archmoj added feature something new and removed bug something broken labels Nov 4, 2018

archmoj added 3 commits November 4, 2018 13:35

removed passes to HTML to unicode for 2D plots

07aecd1

Revert "removed passes to HTML to unicode for 2D plots"

88fef7a

This reverts commit 07aecd1.

removed convert html to unicode only for ticks

29a3cc0

etpinard added this to the v1.43.0 milestone Nov 5, 2018

archmoj mentioned this pull request Nov 13, 2018

Implementation of break lines, sub & superscripts as well as bold & italic styles mikolalysenko/vectorize-text#8

Merged

archmoj commented Nov 13, 2018

View reviewed changes

archmoj added 3 commits November 15, 2018 23:38

using new modules that enable styletags

7cd1be8

enable tags

6e8206e

revised vectorize-text text-cache gl-axes3d and gl-scatter3d modules

113fb63

archmoj commented Nov 16, 2018

View reviewed changes

archmoj added 2 commits November 16, 2018 14:16

removed unused variable

5bba5e7

replace break-lines on 3d plot ticks when the axis type is date

a7d9ac3

using new set of modules that use vectorize-text 3.2.0

9ece9ab

archmoj closed this Nov 19, 2018

archmoj reopened this Nov 19, 2018

Merge branch 'master' into issue-br3d

2c5a70a

etpinard reviewed Nov 19, 2018

View reviewed changes

one fixed to https

fc82a19

archmoj merged commit 50ca29e into master Nov 19, 2018

archmoj deleted the issue-br3d branch November 19, 2018 17:22

archmoj mentioned this pull request Dec 18, 2018

Surface graph has issue with small time ranges #3306

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementation of break lines, sub & superscripts and bold & italic styles in WebGL texts #3207

Implementation of break lines, sub & superscripts and bold & italic styles in WebGL texts #3207

archmoj commented Nov 2, 2018 •

edited

Loading

archmoj Nov 2, 2018

archmoj Nov 13, 2018

etpinard commented Nov 14, 2018

archmoj commented Nov 14, 2018

archmoj Nov 16, 2018

archmoj Nov 16, 2018

archmoj Nov 16, 2018

archmoj commented Nov 19, 2018

etpinard commented Nov 19, 2018

etpinard Nov 19, 2018

etpinard commented Nov 19, 2018

etpinard commented Nov 19, 2018

Implementation of break lines, sub & superscripts and bold & italic styles in WebGL texts #3207

Implementation of break lines, sub & superscripts and bold & italic styles in WebGL texts #3207

Conversation

archmoj commented Nov 2, 2018 • edited Loading

archmoj Nov 2, 2018

Choose a reason for hiding this comment

archmoj Nov 13, 2018

Choose a reason for hiding this comment

etpinard commented Nov 14, 2018

archmoj commented Nov 14, 2018

archmoj Nov 16, 2018

Choose a reason for hiding this comment

archmoj Nov 16, 2018

Choose a reason for hiding this comment

archmoj Nov 16, 2018

Choose a reason for hiding this comment

archmoj commented Nov 19, 2018

etpinard commented Nov 19, 2018

etpinard Nov 19, 2018

Choose a reason for hiding this comment

etpinard commented Nov 19, 2018

etpinard commented Nov 19, 2018

archmoj commented Nov 2, 2018 •

edited

Loading